Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webserver errors #759

Merged
merged 6 commits into from Aug 13, 2019
Merged

Fix webserver errors #759

merged 6 commits into from Aug 13, 2019

Conversation

@leodido
Copy link
Member

leodido commented Aug 1, 2019

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

NONE

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I'd like to add (me or someone else) unit tests to this PR too. Anyway it could be merged also just as is.

Does this PR introduce a user-facing change?:

Improvements to how the webserver handles incoming invalid inputs
@poiana poiana requested review from Kaizhe and mstemm Aug 1, 2019
@poiana poiana added the size/M label Aug 1, 2019
@leodido leodido requested a review from fntlnz Aug 1, 2019
@poiana poiana added size/L and removed size/M labels Aug 2, 2019
leodido added 6 commits Aug 1, 2019
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…e of wrong types

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…tions)

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…expected ranges

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@fntlnz fntlnz force-pushed the fix/webserver-errors branch from 346c87c to 2fdbc50 Aug 13, 2019
@fntlnz
fntlnz approved these changes Aug 13, 2019
@poiana poiana added the lgtm label Aug 13, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Aug 13, 2019

LGTM label has been added.

Git tree hash: f774b043d00f5b13457fd2e8108e1387fcc7a77f

@poiana

This comment has been minimized.

Copy link

poiana commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Aug 13, 2019
@fntlnz fntlnz merged commit 3a1ab88 into dev Aug 13, 2019
6 of 7 checks passed
6 of 7 checks passed
tide Not mergeable. Job Travis CI - Pull Request has not succeeded.
Build Build Successful
Details
Run tests All tests passed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/jenkins/branch This commit looks good
Details
dco All commits have Signed-off-by
Details
@poiana poiana deleted the fix/webserver-errors branch Aug 13, 2019
@fntlnz fntlnz added this to the 0.18.0 milestone Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.