Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove unused ncurses dependency #1658

Merged
merged 2 commits into from
Jul 29, 2021
Merged

build: remove unused ncurses dependency #1658

merged 2 commits into from
Jul 29, 2021

Conversation

leogr
Copy link
Member

@leogr leogr commented May 24, 2021

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1638

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

leogr added 2 commits May 24, 2021 16:12
Since `libs` version 13ec67ebd23417273275296813066e07cb85bc91

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Since `libs` version 13ec67ebd23417273275296813066e07cb85bc91

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr added this to the 0.29.0 milestone May 24, 2021
@leogr leogr modified the milestones: 0.29.0, 0.30.0 Jun 17, 2021
@leogr leogr requested review from leodido and fntlnz June 23, 2021 11:22
@leodido
Copy link
Member

leodido commented Jun 29, 2021

/check-dco

@poiana
Copy link

poiana commented Jun 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member Author

leogr commented Jul 29, 2021

I'm going to merge this manually since tide unfortunately is in a stall situation and is not able to merge this PR anymore :(
Screenshot from 2021-07-29 16-47-22

@leogr leogr merged commit 7dcbeb1 into master Jul 29, 2021
@poiana poiana deleted the chore/remove-ncurses branch July 29, 2021 16:20
@leogr leogr changed the title chore: remove ncurses dependency build: remove unused ncurses dependency Sep 28, 2021
leogr added a commit to falcosecurity/falco-website that referenced this pull request Feb 24, 2022
Removed in Falco since 0.30.0.
See falcosecurity/falco#1658

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
poiana pushed a commit to falcosecurity/falco-website that referenced this pull request Feb 24, 2022
Removed in Falco since 0.30.0.
See falcosecurity/falco#1658

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ncurses dep will be not required anymore
5 participants