Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(test): upgrade urllib3 to 1.26.5 #1666

Merged
merged 1 commit into from Jun 4, 2021
Merged

Conversation

leogr
Copy link
Member

@leogr leogr commented Jun 4, 2021

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

urllib3 is a dependency used in our test suite. Version v1.25.9 is affected by a security vulnerability (CVE-2021-33503) which has been fixed in v1.26.5.

See:

Note that the above dependency is not directly used by Falco.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.29.0

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link

poiana commented Jun 4, 2021

LGTM label has been added.

Git tree hash: 0173e1d5616598151e5c17c5a91e7cc141750bb7

@leogr
Copy link
Member Author

leogr commented Jun 4, 2021

/approve

@poiana
Copy link

poiana commented Jun 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Jun 4, 2021
@poiana poiana merged commit c60fac9 into master Jun 4, 2021
@poiana poiana deleted the test/upgrade-urllib3 branch June 4, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants