Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate allowed ecr registry rule #1725

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

TomKeyte
Copy link
Contributor

@TomKeyte TomKeyte commented Sep 9, 2021

What type of PR is this?

/kind cleanup
/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:
Removes a duplicate ECR repo starts_with rule in the allowed_aws_ecr_registry_root_for_eks macro

Which issue(s) this PR fixes:

NONE

@poiana
Copy link

poiana commented Sep 9, 2021

Welcome @TomKeyte! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/XS label Sep 9, 2021
Signed-off-by: Tom Keyte <tom.keyte@onsecurity.co.uk>
@TomKeyte
Copy link
Contributor Author

TomKeyte commented Sep 9, 2021

/assign @mstemm

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you :)

/approve

@poiana
Copy link

poiana commented Sep 13, 2021

LGTM label has been added.

Git tree hash: 1d7aa63c3a8201f56e510d353c5ca82c85bdb637

@poiana
Copy link

poiana commented Sep 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, TomKeyte

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Sep 13, 2021

/milestone 0.30.0

@poiana poiana added this to the 0.30.0 milestone Sep 13, 2021
@leogr
Copy link
Member

leogr commented Sep 15, 2021

Closing and reopening to trigger CircleCI.
/close

@poiana poiana closed this Sep 15, 2021
@poiana
Copy link

poiana commented Sep 15, 2021

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger CircleCI.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Sep 15, 2021

/reopen

@poiana poiana reopened this Sep 15, 2021
@poiana
Copy link

poiana commented Sep 15, 2021

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Sep 17, 2021

/cc @Kaizhe

Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Falco eyes 👀

LGTM!

@poiana poiana merged commit e0f8b81 into falcosecurity:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants