Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wget and curl to remote_file_copy_binaries (OLD) #1770

Closed

Conversation

erickatwork
Copy link
Contributor

What type of PR is this?

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Added additional binaries that are capable of remote file copy. These binaries are commonly used as a prerequisite to command and control.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?:

rule(Launch Remote File Copy Tools in Container): add additional binaries: curl and wget.

@poiana
Copy link

poiana commented Nov 2, 2021

Welcome @ec4n6! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana
Copy link

poiana commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ec4n6
To complete the pull request process, please assign mstemm after the PR has been reviewed.
You can assign the PR to them by writing /assign @mstemm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from Kaizhe and mstemm November 2, 2021 15:03
@poiana poiana added the size/XS label Nov 2, 2021
Signed-off-by: Erick Cheng <19863605+ec4n6@users.noreply.github.com>
@poiana
Copy link

poiana commented Nov 2, 2021

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@poiana
Copy link

poiana commented Nov 2, 2021

@ec4n6: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@erickatwork
Copy link
Contributor Author

erickatwork commented Nov 2, 2021

Opening a new PR due to commit and merge fails.

See: #1771

@erickatwork erickatwork closed this Nov 2, 2021
@erickatwork erickatwork deleted the add-wget-curl-rules branch November 2, 2021 15:22
@erickatwork erickatwork changed the title Add wget and curl to remote_file_copy_binaries Add wget and curl to remote_file_copy_binaries (OLD) Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants