Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wget and curl to remote_file_copy_binaries #1771

Merged

Conversation

erickatwork
Copy link
Contributor

What type of PR is this?

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Added additional binaries that are capable of remote file copy. These binaries are commonly used as a prerequisite to command and control.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?:

rule(Launch Remote File Copy Tools in Container): add additional binaries: curl and wget.

rules/falco_rules.yaml Outdated Show resolved Hide resolved
rules/falco_rules.yaml Outdated Show resolved Hide resolved
rules/falco_rules.yaml Outdated Show resolved Hide resolved
@leogr
Copy link
Member

leogr commented Nov 18, 2021

Hey @ec4n6

Tests are failing 👇

Tue Nov 16 09:46:11 2021: Runtime error: Could not load rules file /etc/falco/falco_rules.yaml: 1 errors:
Compilation error when compiling "proc.name = curl and (proc.cmdline contains (" > ") or proc.cmdline contains (" >> ") or proc.cmdline contains (" | "))": 45: syntax error, unexpected '(', expecting 'BareString', 'String', 'Number'
---
-  macro: curl_download
   condition: proc.name = curl and (proc.cmdline contains (" > ") or proc.cmdline contains (" >> ") or proc.cmdline contains (" | "))
---
. Exiting.

I guess the round brackets are not needed around strings.

@poiana poiana added size/M and removed size/S labels Nov 18, 2021
Kaizhe
Kaizhe previously approved these changes Nov 18, 2021
rules/falco_rules.yaml Show resolved Hide resolved
@poiana poiana added the lgtm label Nov 18, 2021
@poiana
Copy link

poiana commented Nov 18, 2021

LGTM label has been added.

Git tree hash: e012ad4708ea6ca230b33bcc2d575d6d6f99f1af

@leogr
Copy link
Member

leogr commented Nov 19, 2021

Closing and reopening to trigger the CI
/close

@poiana poiana closed this Nov 19, 2021
@poiana
Copy link

poiana commented Nov 19, 2021

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Nov 19, 2021

/reopen

@poiana
Copy link

poiana commented Nov 19, 2021

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana reopened this Nov 19, 2021
@leogr
Copy link
Member

leogr commented Nov 19, 2021

/milestone 0.31.0

Signed-off-by: Erick Cheng <19863605+ec4n6@users.noreply.github.com>
Signed-off-by: Erick Cheng <19863605+ec4n6@users.noreply.github.com>
Signed-off-by: Erick Cheng <19863605+ec4n6@users.noreply.github.com>
Signed-off-by: Erick Cheng <19863605+ec4n6@users.noreply.github.com>
Signed-off-by: Erick Cheng <19863605+ec4n6@users.noreply.github.com>
@erickatwork
Copy link
Contributor Author

@leogr Hi, it looks like my merge is missing the DCO signoff. Is this necessary, and if so, how do I add signoff to an existing merge?

@leogr
Copy link
Member

leogr commented Nov 24, 2021

/check-dco

@leogr
Copy link
Member

leogr commented Nov 24, 2021

@leogr Hi, it looks like my merge is missing the DCO signoff. Is this necessary, and if so, how do I add signoff to an existing merge?

Merge commits are not allowed, but it seems to me you already removed it. Indeed, after checking for DCO again, now it's all fine. Thank you!

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/approve

@Kaizhe could you check again? Thank you 🙏

@poiana
Copy link

poiana commented Nov 24, 2021

LGTM label has been added.

Git tree hash: 788fefea0a448c7688afcf4b2905e05092b73dc9

@poiana
Copy link

poiana commented Nov 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ec4n6, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@erickatwork
Copy link
Contributor Author

Bump @Kaizhe

@poiana poiana merged commit 205a8fd into falcosecurity:master Nov 29, 2021
@erickatwork erickatwork deleted the add-wget-curl-to-remote-file-copy branch November 30, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants