update: support non-enumerable event sources in gRPC outputs service #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
|
LGTM label has been added. Git tree hash: 4af96c41d4cde004f665de34f62bd097a2c59cba
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.31.0 |
mstemm
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind design
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
See #1826 for details about the issue.
This deprecates the
sourcefield inoutputs.proto, and adds aPLUGINentry in the source enum. The goal is to maintain backward compatibility for clients relying on old protobufs versions. Accordingly, a new string field for the event source is added. This is required by plugin system, as the source name is determined by the source plugin loaded and it's not enumerable anymore.Which issue(s) this PR fixes:
Fixes #1826
Special notes for your reviewer:
Does this PR introduce a user-facing change?: