Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): try to use root user for cimg/base #2045

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 8, 2022

Signed-off-by: Federico Di Pierro nierro92@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Moreover, fixed buildx usage.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana poiana added the lgtm label Jun 8, 2022
@poiana
Copy link

poiana commented Jun 8, 2022

LGTM label has been added.

Git tree hash: 84aea481b19c7350169c6dc85b4c495b374ff999

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Jun 8, 2022
@leogr
Copy link
Member

leogr commented Jun 8, 2022

/override ci/circleci

@leogr
Copy link
Member

leogr commented Jun 8, 2022

/poiana

@poiana
Copy link

poiana commented Jun 8, 2022

@leogr: Poiana stops the drama!

In response to this:

/poiana

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana merged commit 0a98e11 into falcosecurity:master Jun 8, 2022
@FedeDP FedeDP deleted the fix/docker_user branch June 8, 2022 09:14
@jasondellaluce
Copy link
Contributor

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Jun 8, 2022
@jasondellaluce jasondellaluce modified the milestones: 0.33.0, 0.32.1 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants