Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(falco_scripts): Change Flatcar dynlinker path #2066

Merged

Conversation

jepio
Copy link
Contributor

@jepio jepio commented Jun 15, 2022

What type of PR is this?
/kind bug

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:
glibc 2.34 will remove the dynamic linker symlink that the script currently relies on when building for Flatcar. Fix the dynamic linker path to one that is present in all glibc version.

Which issue(s) this PR fixes:

Follow-up to #2043.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

The Flatcar kernel module build needs to relocate binaries in /host/lib/modules
to run with the host's ld and glibc. While testing with glibc 2.34 that we plan
to introduce soon, we found that the previous dynlinker symlink (ld-xxx.so)
doesn't exist any longer. Update the hostld variable to use a path that is
present in all versions of glibc.

Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Jun 16, 2022

LGTM label has been added.

Git tree hash: d88e605555f07004ffd856d64c0daabd77981f89

@poiana
Copy link

poiana commented Jun 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, jepio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Jun 17, 2022

/milestone 0.32.1

@poiana poiana added this to the 0.32.1 milestone Jun 17, 2022
@leogr
Copy link
Member

leogr commented Jun 17, 2022

Closing and reopening to trigger the CI.
/close

@poiana poiana closed this Jun 17, 2022
@poiana
Copy link

poiana commented Jun 17, 2022

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger the CI.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Jun 17, 2022

/reopen

@poiana poiana reopened this Jun 17, 2022
@poiana
Copy link

poiana commented Jun 17, 2022

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana merged commit bcda81f into falcosecurity:master Jun 17, 2022
@LucaGuerra LucaGuerra mentioned this pull request Jun 22, 2022
15 tasks
@jepio jepio deleted the driver-loader-flatcar-fix-dynlink-path branch November 23, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants