Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(scripts): add bottlerocket support in falco-driver-loader. #2318

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Dec 13, 2022

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

What this PR does / why we need it:

Adds support for bottlerocket OS in falco-driver-loader script.
See relevant PRs:

Kernel-crawler will output a json similar to the minikube one:

{
"kernelversion": "1_1.11.1-vmware",
"kernelrelease": "5.15.59",
"target": "bottlerocket",
"kernelconfigdata": "..."
}

Basically, kernelversion ships OS version (_1.11.1) and flavor (-vmware).
Therefore, the changes in falco-driver-loader.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(scripts): add bottlerocket support in falco-driver-loader

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 14, 2022

Wait on falcosecurity/kernel-crawler#79 to be merged first.

@FedeDP FedeDP changed the title wip: new(scripts): add bottlerocket support in falco-driver-loader. new(scripts): add bottlerocket support in falco-driver-loader. Dec 16, 2022
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 16, 2022

Kernel-crawler PR was merged.

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 19, 2022

We now have bottlerocket entries in kernel-crawler generated json: https://falcosecurity.github.io/kernel-crawler/?arch=x86_64&target=BottleRocket.

I think this is safe to be merged ;)
/milestone 0.34.0

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Dec 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9d2f1e0 into master Dec 19, 2022
@poiana poiana deleted the new/driver-loader-bottlerocket branch December 19, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants