Add runc to the list of possible container entrypoint parents #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fntlnz
previously approved these changes
Jul 9, 2019
|
LGTM label has been added. Git tree hash: 7b5aa33ff18ffbf98376d5bd754a2d68b9040acf
|
|
Great @mattpag ! Good catch! |
|
@mattpag thanks! Could you please rebase it? |
Docker versions >= 18.09 removed the "docker-" prefix, so include runc in the list. Signed-off-by: Mattia Pagnozzi <mattia.pagnozzi@gmail.com>
mattpag
force-pushed
the
expand-entrypoint-macro
branch
from
f826775
to
221d641
Compare
|
@leodido done |
leodido
approved these changes
Jul 9, 2019
|
LGTM label has been added. Git tree hash: f05562ff2c4a14b7328157fca413d5a947e7d6de
|
|
/lgtm |
fntlnz
approved these changes
Jul 9, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, Kaizhe, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Add
runcto the list of possible parents in thecontainer_entrypointmacro since thedocker-prefix added to the binary has been removed starting with Docker CE version 18.09.Without this, rules like "Terminal shell in container" were not triggered when expected while using recent Docker releases.
See https://github.com/docker/docker-ce/releases/tag/v18.09.0 ("Remove 'docker-' prefix for containerd and runc binaries docker-archive/engine#61 / moby/moby#37907, docker/docker-ce-packaging#241")
Special notes for your reviewer:
Does this PR introduce a user-facing change?: