Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: strict checks on hidden files and repository files that are modified #766

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@fntlnz
Copy link
Member

fntlnz commented Aug 13, 2019

Signed-off-by: Lorenzo Fontana lo@linux.com

What type of PR is this?

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

In "Create Hidden Files or Directories", when a directory or a file is created the rule is triggered but it should also trigger when a file or directory is moved to become and hidden one, this PR uses the modify macro to do that additional check.

In "Update Package Repository" when a directory or a file is updated in the sensitive packages folder the rule is triggered, however it was not triggered when a file is moved into those directories. This PR fixes that using the modify macro.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rules: "Create Hidden Files or Directories" and "Update Package Repository" now trigger also if the files are moved and not just if modified or created.
@poiana poiana requested review from Kaizhe and mfdii Aug 13, 2019
@fntlnz fntlnz changed the title Rules: strict checks on hidden files and repository files that are modified rules: strict checks on hidden files and repository files that are modified Aug 13, 2019
@leodido leodido self-requested a review Aug 13, 2019
Copy link
Member

leodido left a comment

SGTM

(needs a rebase)

@poiana poiana added the lgtm label Aug 13, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Aug 13, 2019

LGTM label has been added.

Git tree hash: f7604229178be9c568a5199b605deee397393199

@poiana poiana added the approved label Aug 13, 2019
@fntlnz fntlnz force-pushed the fix/modify-trigger branch from 3581fea to 9915013 Aug 14, 2019
@poiana poiana removed lgtm approved labels Aug 14, 2019
@fntlnz fntlnz requested a review from leodido Aug 14, 2019
@fntlnz fntlnz force-pushed the fix/modify-trigger branch from 9915013 to 4cc1d10 Aug 16, 2019
@kris-nova

This comment has been minimized.

Copy link
Member

kris-nova commented Aug 16, 2019

/lgtm

@poiana

This comment has been minimized.

Copy link

poiana commented Aug 16, 2019

LGTM label has been added.

Git tree hash: a694ec47a73fc4a888ac8e4f3d516d296100b3f6

@poiana poiana added the approved label Aug 16, 2019
… or created

Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz fntlnz force-pushed the fix/modify-trigger branch from 4cc1d10 to fa138bc Aug 19, 2019
@poiana poiana removed the lgtm label Aug 19, 2019
@leodido leodido self-requested a review Aug 19, 2019
@poiana poiana added the lgtm label Aug 19, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Aug 19, 2019

LGTM label has been added.

Git tree hash: e950fc67927b1612c61d2e0f891707f279cbc2a2

@poiana

This comment has been minimized.

Copy link

poiana commented Aug 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kris-nova, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz fntlnz merged commit 39b5156 into dev Aug 20, 2019
6 of 7 checks passed
6 of 7 checks passed
tide Not mergeable. Job Travis CI - Pull Request has not succeeded.
Build Build Successful
Details
Run tests All tests passed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/jenkins/branch This commit looks good
Details
dco All commits have Signed-off-by
Details
@poiana poiana deleted the fix/modify-trigger branch Aug 20, 2019
@leodido leodido added this to the 0.18.0 milestone Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.