Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal): old ebpf probe must have lowest priority. #521

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Apr 18, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area library

What this PR does / why we need it:

See falcosecurity/falco#3173

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@FedeDP
Copy link
Contributor Author

FedeDP commented Apr 18, 2024

/milestone v0.8.0

@poiana poiana requested review from loresuso and zuc April 18, 2024 08:54
@poiana poiana added this to the v0.8.0 milestone Apr 18, 2024
@poiana poiana added the size/XS label Apr 18, 2024
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the chore/old_ebpf_lowest_prio branch from 9479cfa to 88037f8 Compare April 18, 2024 09:00
@poiana poiana added size/S and removed size/XS labels Apr 18, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Apr 18, 2024

/cc @leogr

@poiana poiana requested a review from leogr April 18, 2024 13:46
Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@poiana
Copy link
Contributor

poiana commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f7bcb4a into main Apr 19, 2024
17 checks passed
@poiana poiana deleted the chore/old_ebpf_lowest_prio branch April 19, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants