fix: introduce a COS workaround to fix regression #1157 #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
poiana
added
release-note-none
kind/bug
FedeDP
reviewed
Jun 22, 2023
|
LGTM label has been added. Git tree hash: 3b8a1b89774ae57c069d73d565290d2c0887b58e
|
43 tasks
erthalion
approved these changes
Jun 22, 2023
|
@erthalion: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jasondellaluce
approved these changes
Jun 22, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, erthalion, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Andreagit97
added a commit
to Andreagit97/libs
that referenced
this pull request
Dec 5, 2023
This PR falcosecurity#1160 is no more necessary since the issue is now fixed in libbpf library Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
poiana
pushed a commit
that referenced
this pull request
Dec 5, 2023
This PR #1160 is no more necessary since the issue is now fixed in libbpf library Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-modern-bpf
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR fixes the regression reported here #1157 as suggested by @FedeDP.
I want to highlight that this is just a temp workaround for tag 0.11.3 we need to find for sure a better solution, hoping to receive some inputs from kernel engineers https://lore.kernel.org/bpf/CAGQdkDvYU_e=_NX+6DRkL_-TeH3p+QtsdZwHkmH0w3Fuzw0C4w@mail.gmail.com/T/#u
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: