Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(driver/ppm_fillers.c): create consistencies (s32 to int32_t) #1434

Merged
merged 1 commit into from Oct 24, 2023
Merged

cleanup(driver/ppm_fillers.c): create consistencies (s32 to int32_t) #1434

merged 1 commit into from Oct 24, 2023

Conversation

ecbadeaux
Copy link
Contributor

@ecbadeaux ecbadeaux commented Oct 22, 2023 •
edited

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area driver-kmod

Does this PR require a change in the driver versions?

No.

What this PR does / why we need it:

Make driver code more consistent.

Which issue(s) this PR fixes:

part of #902
(partial fix other issues still remain in 902)

Special notes for your reviewer:

Tagging @dwindsor for visibility.

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Oct 22, 2023

@ecbadeaux: The label(s) area/driver cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area driver

Does this PR require a change in the driver versions?

No.

What this PR does / why we need it:

Make driver code more consistent.

Which issue(s) this PR fixes:

part of #902
(partial fix other issues still remain in 902)

Special notes for your reviewer:

Tagging @dwindsor for visibility.

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana requested a review from mstemm October 22, 2023 04:25
@poiana poiana added the size/L label Oct 22, 2023
@github-actions
Copy link

Please double check driver/API_VERSION file. See versioning.

/hold

incertum
incertum previously approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Oct 23, 2023
@poiana
Copy link
Contributor

poiana commented Oct 23, 2023

LGTM label has been added.

Git tree hash: e194102fd27d61d234d394cd1317f3b912667f80

@Andreagit97
Copy link
Member

Andreagit97 commented Oct 23, 2023 •
edited

Thank you for this! After merging this #1435 we have a conflict with master so you need to rebase :/

@Andreagit97 Andreagit97 added this to the 0.14.0 milestone Oct 23, 2023
@poiana poiana removed the lgtm label Oct 23, 2023
@poiana poiana requested a review from incertum October 23, 2023 22:47
@ecbadeaux
cleanup(driver/ppm_fillers.c): create consistencies (s32 to int32_t)
2c1f316 
Signed-off-by: Everett Badeaux <everettc1810@gmail.com>
@ecbadeaux
Copy link
Contributor Author

ecbadeaux commented Oct 23, 2023 •
edited

Should be ready, just rebased. @Andreagit97 @incertum

incertum
incertum approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Oct 24, 2023
@poiana
Copy link
Contributor

poiana commented Oct 24, 2023

LGTM label has been added.

Git tree hash: 4ce8fccc56573cd8e5e54104cea4dad7280965ba

FedeDP
FedeDP approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecbadeaux, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Oct 24, 2023

/unhold

@poiana poiana merged commit 5c9b3cd into falcosecurity:master Oct 24, 2023
36 checks passed
@ecbadeaux ecbadeaux deleted the fix_driver_inconsistencies_s32 branch October 25, 2023 03:27
@FedeDP
Copy link
Contributor

FedeDP commented Oct 25, 2023

/milestone next-driver

@poiana poiana modified the milestones: 0.14.0, next-driver Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@incertum incertum incertum approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@FedeDP FedeDP

@incertum incertum

Labels
approved dco-signoff: yes kind/bug Something isn't working kind/cleanup lgtm release-note-none size/L
Projects
None yet
Milestone
7.0.0+driver
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ecbadeaux @poiana @Andreagit97 @FedeDP @incertum