[CLEANUP] Drivers inconsistencies

[loresuso]

While working on our drivers I am noticing many inconsistencies.

For instance:

• we indistinguishably use s32 and int32_t types. I think we should use one or the other for consistency, and I would use the _t ones because are defined by the C standard.
• in our kmod, there is a macro CHECK_RES that can be used to check if a previous operation succeeded or not. It is not consistently used in the whole file.
• there is a syscall_arg_t type that is seldom used throughout the file.

Still adding things to this. Once we are done with introducing syscall for modern probe we can think about this!

[poiana]

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

[loresuso]

/remove-lifecycle stale

[incertum]

@Andreagit97 any thoughts on s32 and int32_t types in old bpf and modern bpf?

[Andreagit97]

uhm I agree with @loresuso one day or another we should convert all s... to int... but I would say it's just a matter of style not so urgent

[incertum]

ok

[ecbadeaux]

The CHECK_RES issue should be marked as completed like this example

[ecbadeaux]

The syscall_arg_t should be marked as completed as well @Andreagit97 :)

[ecbadeaux]

@incertum Can you close this issue?

[loresuso]

Thanks for your work @ecbadeaux !

[FedeDP]

/milestone next-driver