cleanup(driver/ppm_fillers.c): create consistencies (u16 to uint16_t) #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
|
Please double check driver/API_VERSION file. See versioning. /hold |
|
Thank you for this! After merging this #1435 we have a conflict with master so you need to rebase :/ |
|
@ecbadeaux also need a rebase here, ty! |
Signed-off-by: Everett Badeaux <everettc1810@gmail.com>
@incertum Should be good now please approve! |
|
LGTM label has been added. Git tree hash: f84814f8441fe2a0f70cf180485bacefa8d93be3
|
|
/milestone next-driver |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecbadeaux, FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area driver-kmod
Does this PR require a change in the driver versions?
No.
What this PR does / why we need it:
Make driver code more consistent. (u16 -> uint16_t)
Which issue(s) this PR fixes:
part of #902
(partial fix other issues still remain in 902)
Special notes for your reviewer:
Going to be gradually creating integer consistency across the codebase. Best to keep the reviews small.
Tagging @dwindsor for visibility.
Does this PR introduce a user-facing change?: