Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(driver/bpf/filler_helpers.h) inconsistent int types #1460

Closed
wants to merge 5 commits into from
Closed

cleanup(driver/bpf/filler_helpers.h) inconsistent int types #1460

wants to merge 5 commits into from

Conversation

ecbadeaux
Copy link
Contributor

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area driver-bpf

Does this PR require a change in the driver versions?

No.

What this PR does / why we need it:

Make bpf code more consistent.

Which issue(s) this PR fixes:

part of #902
(partial fix other issues still remain in 902)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Everett Badeaux <everettc1810@gmail.com>
Signed-off-by: Everett Badeaux <everettc1810@gmail.com>
@incertum
Copy link
Contributor

@ecbadeaux how many PRs are still pending, perhaps we can consolidate just a bit? To have maybe just 2-3PRs instead of 5+?

@ecbadeaux
Copy link
Contributor Author

@ecbadeaux how many PRs are still pending, perhaps we can consolidate just a bit? To have maybe just 2-3PRs instead of 5+?

@incertum I can gladly close this MR and knock them all out. I was keeping these MR's small so someone wouldn't have to read an XXXXXL merge request.

Let me know what you'd prefer. Seems like you are the main reviewer anyways.

@incertum
Copy link
Contributor

Maybe partition changes over 2-3 PRs in total? This should probably be ok to review. You can decide on how to partition.

@ecbadeaux
Copy link
Contributor Author

@incertum Are we going to merge these or do you want me to close them?

@incertum
Copy link
Contributor

How about just re pushing on both and adding commits? We can review commit by commit.

cleanup(bpf/fillers.h): create integer consistencies all types
@poiana
Copy link
Contributor

poiana commented Nov 1, 2023

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added size/XL and removed size/L labels Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Please double check driver/API_VERSION file. See versioning.

/hold

@poiana
Copy link
Contributor

poiana commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ecbadeaux
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added size/XXL and removed size/XL labels Nov 1, 2023
@ecbadeaux
Copy link
Contributor Author

@incertum I'll tag you again when all of this is ready to be reviewed.

@incertum
Copy link
Contributor

incertum commented Nov 1, 2023

Sounds good, ah you need to remove the merge commit, always only use rebase. Ty!

Signed-off-by: Everett Badeaux <everettc1810@gmail.com>
@poiana
Copy link
Contributor

poiana commented Nov 1, 2023

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ecbadeaux
Copy link
Contributor Author

Closing to reopen with clean branch and commits (follow the conversation above)

@ecbadeaux ecbadeaux closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants