fix(userspace/libsinsp): restore support to containers #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attempts fixing a regression introduced in 6332c34 Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
poiana
added
release-note-none
kind/bug
|
/milestone 0.14.0 |
incertum
approved these changes
Dec 1, 2023
|
LGTM label has been added. Git tree hash: 571ee2db0b01b08a53fcca303cc93d46285a6678
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, incertum, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
This attempts amending a regression in the resolution logic of containers, introduced in #1520.
It took me a couple of hours to figure this out. @incertum can you provide some context of what was the intention of this specific change? From my understanding this has the potential of entirely disabling support to containers.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: