Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add monitoring of mprotect parameters #174

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

loresuso
Copy link
Member

@loresuso loresuso commented Jan 10, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-ebpf

/area libscap

/area libsinsp

/area tests

/area proposals

What this PR does / why we need it:
I noticed that we were missing monitoring parameters of the mprotect syscall. I think that the latter can be used for malicious purposes, for instance:

  • in ROP chains to make the stack executable again to bypass the NX protection and execute shellcode injected on it. (transition W->X)
  • malware that self-modifies, injecting useless instructions to avoid detection like push/pop from stack, add/subtract the same register, and so on (transition X->W->X)
  • unpacker that decrypts/uncompresses malware in memory and make it executable

In general, it may be interesting monitoring pages permissions transitions: every time a page passes from writable permissions to executable ones and vice versa, it may be a clue of something malicious going on. These transitions may be monitored by inspecting /proc/<pid>/maps on process startup and using the parameters of every mprotect and mmap syscalls to check if a valid transition occurred or not. Let me know what do you think about this, maybe we can use this PR to share more ideas!

You can test this system call with this simple C program.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update: add monitoring of mprotect parameters

Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
@poiana
Copy link
Contributor

poiana commented Jan 10, 2022

Hi @loresuso. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the size/L label Jan 10, 2022
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you!

@poiana
Copy link
Contributor

poiana commented Jan 11, 2022

@FedeDP: changing LGTM is restricted to collaborators

In response to this:

This is great! Thank you!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce
Copy link
Contributor

This is great!!

@FedeDP
Copy link
Contributor

FedeDP commented Jan 17, 2022

/ok-to-test

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 18, 2022

LGTM label has been added.

Git tree hash: 3d6af6c5775505216a7a2d7bcb8282e0f61c1e9a

@poiana
Copy link
Contributor

poiana commented Jan 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants