-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move definitions to inner CMakeLists.txt(s) and correct add_user/add_group #361
Conversation
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
CC @gnosek |
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…group Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/test build-libs-bundled-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
/area libsinsp
What this PR does / why we need it:
While testing the latest libs version on Falco, we noticed that user names were not correctly looked up. Digging into the problem, we discovered that a feature gate 👇 was off when building Falco
libs/userspace/libsinsp/user.cpp
Lines 151 to 163 in bd94f31
After a further investigation, we realized the root problem was that the
add_definition
was included in CompilerFlags.cmake, which is not used by client projects (like Falco).This PR moves relevant compiler definitions in cmake module files (intended to be used by client projects).
UPDATE:
We also found a bug in
add_user
andadd_group
. Fixed by 7afbad4Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This hotfix is needed to release Falco 0.32
Does this PR introduce a user-facing change?: