Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(driverkit/config): add driver version 39ae7d40496793cf3d3e7890c9bbdc202263836b #709

Merged
merged 3 commits into from
May 31, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 26, 2022

They will be used by Falco 0.32.0 that is currently freezing libs version.
Wip for now until falcosecurity/falco#2024 is merged.

@leogr
Copy link
Member

leogr commented May 26, 2022

/test build-new-drivers-ubuntu-generic-5-presubmit

leogr
leogr previously approved these changes May 26, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the candidate driver version for Falco 0.32

/approve

I'm putting this on hold while we are testing the latest build of Falco

/hold

Once we are confident that Falco works as expected with this driver version, feel free to unhold.

Thank you 🙏

@poiana
Copy link
Contributor

poiana commented May 26, 2022

LGTM label has been added.

Git tree hash: 3de8767005c72b87b867264a81abea5a510bbad7

@leogr
Copy link
Member

leogr commented May 26, 2022

/test build-new-drivers-centos-presubmit

@leogr
Copy link
Member

leogr commented May 26, 2022

We have to bump the driver version again because of falcosecurity/libs#361 :(

@poiana poiana removed the lgtm label May 26, 2022
@poiana poiana requested a review from leogr May 26, 2022 15:46
@FedeDP FedeDP changed the title wip: new(driverkit/config): add driver version bd94f3189774e5298dd383bf913da7b3b620a94a wip: new(driverkit/config): add driver version 1be924900a09cf2e4db4b4ae13d03d838959f350 May 26, 2022
@FedeDP
Copy link
Contributor Author

FedeDP commented May 26, 2022

poiana 🙏

@FedeDP FedeDP changed the title wip: new(driverkit/config): add driver version 1be924900a09cf2e4db4b4ae13d03d838959f350 new(driverkit/config): add driver version 1be924900a09cf2e4db4b4ae13d03d838959f350 May 26, 2022
leogr
leogr previously approved these changes May 26, 2022
@poiana poiana added the lgtm label May 26, 2022
@poiana
Copy link
Contributor

poiana commented May 26, 2022

LGTM label has been added.

Git tree hash: 24222f1d8e0e91019c01ac677d690e6f5e814c08

@FedeDP FedeDP changed the title new(driverkit/config): add driver version 1be924900a09cf2e4db4b4ae13d03d838959f350 wip: new(driverkit/config): add driver version 1be924900a09cf2e4db4b4ae13d03d838959f350 May 26, 2022
…da7b3b620a94a.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
…03d838959f350 driver version.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
…c9bbdc202263836b

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana poiana removed the lgtm label May 31, 2022
@poiana poiana requested a review from leogr May 31, 2022 15:33
@FedeDP FedeDP changed the title wip: new(driverkit/config): add driver version 1be924900a09cf2e4db4b4ae13d03d838959f350 wip: new(driverkit/config): add driver version 39ae7d40496793cf3d3e7890c9bbdc202263836b May 31, 2022
@FedeDP
Copy link
Contributor Author

FedeDP commented May 31, 2022

New driverversion: 39ae7d40496793cf3d3e7890c9bbdc202263836b

@FedeDP FedeDP changed the title wip: new(driverkit/config): add driver version 39ae7d40496793cf3d3e7890c9bbdc202263836b new(driverkit/config): add driver version 39ae7d40496793cf3d3e7890c9bbdc202263836b May 31, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label May 31, 2022
@poiana
Copy link
Contributor

poiana commented May 31, 2022

LGTM label has been added.

Git tree hash: ffcfdcc50c9d21d7aea224cd4d16fcdfd12bcfc5

@poiana
Copy link
Contributor

poiana commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented May 31, 2022

/test build-new-drivers-ubuntu-generic-3-presubmit

@leogr
Copy link
Member

leogr commented May 31, 2022

/unhold

@poiana poiana merged commit fab57eb into falcosecurity:master May 31, 2022
@FedeDP FedeDP deleted the new/drivers-falco-0.32.0 branch June 1, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants