fix(userspace/libsinsp): define HAVE_PWD_H and HAVE_GRP_H on every non-windows system #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-windows system Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
poiana
added
release-note-none
kind/bug
|
See falcosecurity/falco#2048 for the issue! Thanks @jasondellaluce ! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 8b984f75266d48d4d7ffe34894c86a0947f0210c
|
leogr
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
HAVE_PWD_HandHAVE_GRP_Hrepresent feature gates in libsinsp, which are expected to be compiled in any non-windows system. However, those definitions are added depending on the presence of an include file using CMake, which seems to be non-totally predictable in all systems. In case this section is now compiled, libsinsp fails to consistently fetch user data and extract fields such asuser.name.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: