new(scap): Support gVisor no_events mode/full proc scan for nodriver #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Angelo Puglisi <angelopuglisi86@gmail.com> Signed-off-by: Angelo Puglisi <angelopuglisi86@gmail.com> Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
The nodriver engine is still the only user of limited /proc scan but we no longer check handle->m_mode. Instead we have a dedicated flag. This lets us have the nodriver engine with a full /proc scan if we want. Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
The patch is somewhat weird because it introduces an option for the nodriver engine which is used only by the main libscap code (the /proc scan does not live in the engine). Still, we're (logically) configuring the nodriver engine, I believe the flag belongs in the engine config. Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
This new flag means that we're *not* going to get any events from the engine and are using it just for the secondary effects of scap_open (mostly getting the process table). This is needed to safely open a new inspector while another one exists. Otherwise we'd overwrite the gVisor socket with a new one (which would become inactive the moment we close the second inspector), breaking all future gVisor connections. Co-Authored-By: Angelo Puglisi <angelopuglisi86@gmail.com> Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
poiana
added
release-note-none
do-not-merge/work-in-progress
kind/feature
Andreagit97
approved these changes
Mar 21, 2023
|
LGTM label has been added. Git tree hash: 305303c28bee699f3c873699f4f2a2506d48e1a6
|
|
cc @LucaGuerra |
LucaGuerra
reviewed
Mar 21, 2023
| @@ -97,7 +97,7 @@ engine::~engine() | |||
|
|
|||
| } | |||
|
|
|||
| int32_t engine::init(std::string config_path, std::string root_path) | |||
| int32_t engine::init(std::string config_path, std::string root_path, bool no_events) | |||
There was a problem hiding this comment.
Not related to this change, but we're copying strings here
There was a problem hiding this comment.
I personally don't think copying strings is an issue here. It certainly isn't for this PR :)
LucaGuerra
approved these changes
Mar 21, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, gnosek, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
gnosek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libscap-engine-gvisor
/area libscap-engine-nodriver
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR is a smaller patch to achieve the same thing as #986. Instead of introducing a no_events mode for all engines, it introduces one just for gVisor. kmod/bpf/modern_bpf can use the nodriver engine instead (with the new full_proc_scan=true flag) to achieve the same result.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: