new: introduce plugin loader code #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
release-note
do-not-merge/work-in-progress
kind/feature
jasondellaluce
force-pushed
the
new/loader
branch
from
60b88b7
to
d7632a5
Compare
jasondellaluce
force-pushed
the
new/loader
branch
from
d7632a5
to
aebad9d
Compare
jasondellaluce
changed the title
jasondellaluce
force-pushed
the
new/loader
branch
from
07600fa
to
3fa1774
Compare
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
jasondellaluce
force-pushed
the
new/loader
branch
from
3fa1774
to
c131b2e
Compare
|
/unhold |
leogr
approved these changes
Aug 5, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 49bab32022e779bcd7e02f26235d1a2d67520039
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area plugin-sdk
What this PR does / why we need it:
Which issue(s) this PR fixes:
After the changes in libs of falcosecurity/libs#392 (
yet to get merged), the plugin loading code is isolated in a self-contained package and implements a C api. As such, it is possible to develop loaders in other programming languages by reusing the libs one, which makes it compliant with the targeted libs version out of the box.This first version of the loader is capable of loading plugins, validating them against the currently-supported plugin API version, and reading all their static/descriptive information (name, version, etc...). The loader is also capable of initializing the plugin in order to read initialization-dependent information such as the list of suggested open params.
Special notes for your reviewer:
Blocked and WIP until merging #63.
Since this PR is already big, unit tests and examples will be added in a future PR. Support for more operations on the loaded plugins will be considered in the future.
Most of the changes are related to pulling
plugin_loader.h/.cfrom libs. The actual loader code is ~400 LOC and resides in pkg/loader/loader.go.Does this PR introduce a user-facing change?: