Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudtrail): Add generic additionalEventData field #418

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

uhei
Copy link
Contributor

@uhei uhei commented Feb 23, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area plugins

What this PR does / why we need it:

Similar to ct.request, all values should also be available for additionalEventData.

Copy link

Rules files suggestions

aws_cloudtrail_rules.yaml

Comparing 360a7250a6a5cffb86ca6bfa9e80413bcc3e7bfc with latest tag cloudtrail-0.11.0

No changes detected

@leogr
Copy link
Member

leogr commented Feb 23, 2024

/assign

cc @Issif

Similar to ct.request, all values should also be available for
additionalEventData.

Signed-off-by: Uli Heilmeier <uh@heilmeier.eu>
Copy link

Rules files suggestions

aws_cloudtrail_rules.yaml

Comparing a0fd01e9cc6c5bccdc53bd3e74758a458c8327d2 with latest tag cloudtrail-0.11.0

No changes detected

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

cc @LucaGuerra

@poiana poiana added the lgtm label Feb 23, 2024
@poiana
Copy link
Contributor

poiana commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, uhei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Feb 23, 2024

LGTM label has been added.

Git tree hash: 205aa81ee20fc8f23a1706899c71129550338b69

@poiana poiana merged commit 9a1f86a into falcosecurity:master Feb 23, 2024
11 checks passed
@uhei uhei deleted the feat/ct-addEventDate branch February 23, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants