-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put state of current location/review in Redux #410
Conversation
(co-authored with Claude Sonnet 3.5 via aider-chat by a sequence of fairly mechanistic prompts and tested by reading results and then clicking around tabs, so should be okay)
This PR is ready to go as is, but I started doing more work on top of it, as a warm-up for 3. above. The goal was #407 - in "new position" state, going to settings and back should bring back the marker, which was the most trivial feature that uses saved location data I could think of. Then I found the tabs code, and made the change that closes #411 . |
Done by clearing location in Redux when it goes out of context (visits to /map and /list but not always) x
Now also closes #407 |
Now also closes #412 |
@wbazant This feels like a major step forward! Do you want to merge now or keep building on this branch (e.g. for #359)? After trying out the suggested fix to #412, I agree with my #412 (comment): I think the marker should appear immediately, but the location should only display once the latest pending is fulfilled. |
Sure, I've made the relevant lines like on the other branch. |
The reducers are just in their simplest state - and will probably grow if we put more stuff there, like intermediate states of form or drawer state - and there aren't really any huge benefits from the PR by itself but it should help later. From the original points:
I checked we still do a redirect from a bare URL to the one with coordinates
Opened new issue, #409