[Fix] Simplify taxonomy repository find method #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kont-noor
approved these changes
Feb 18, 2017
tiagoamaro
deleted the
fix/allow-spaces-hyphens-on-taxonomy-repository
branch
gus4no
pushed a commit
that referenced
this pull request
Mar 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me and @sfate just decided to quickly refactor the
Repositories::Taxonomy.get_taxon_by_namemethod after one interesting scenario:Repositories::Taxonomy.get_taxon_by_namewasn't able to find the taxon by its nameNow, taxon names are normalized to a default pattern (parameterized) so they can match without any regexes or edge cases.