Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests + couple of fixes #97

Merged
merged 4 commits into from
Oct 9, 2018
Merged

More tests + couple of fixes #97

merged 4 commits into from
Oct 9, 2018

Conversation

troch
Copy link
Collaborator

@troch troch commented Oct 9, 2018

Fixes:

  • Use Inferno componentWillReceiveProps rather than componentWillUpdate
  • Merge state in setState before component is mounted

Additional tests:

  • Test prop updates on toProps
  • Test prop updates on asProps
  • Test prop updates on render effect

thisRaptori
thisRaptori approved these changes Oct 9, 2018
View reviewed changes
Copy link
Collaborator

@thisRaptori thisRaptori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@troch troch merged commit 998a9fb into master Oct 9, 2018
@troch troch deleted the more-tests branch October 9, 2018 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisRaptori thisRaptori thisRaptori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@troch @thisRaptori