-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SAML user does not exist logging call #185
Open
jpmanthorp
wants to merge
46
commits into
fangli:master
Choose a base branch
from
passth:jm-fixLoggingCalls
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e contents into it
Support dynamic metadata
move saml attributes inside of new user creation
optional saml
use relayState to redirect after login
Add missing migration to package
Make scheme https
Lowercase emails + more logging
Allow blank metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by how we did not use Python's old string formatting operator to inject the problematic id into the log message. This issue caused one of our SAML logging calls to raise its own error last week and consequently the "user not found error" percolated up to a user instead of redirecting them to a denied page. For the sake of clarity, we will now manually format the string injected into the logger (as opposed to allowing the logging module to only generate the final msg if the log would actually be produced) as this is a fairly inexpensive operation.
See logs here