Skip to content

Commit

Permalink
asm: add .note.GNU-stack section for non-exec stack
Browse files Browse the repository at this point in the history
With this in place, we no-longer see warnings like the following:
```bash
/usr/lib/gcc-cross/arm-linux-gnueabihf/12/../../../../arm-linux-gnueabihf/bin/ld: warning: field_10x26_arm.o: missing .note.GNU-stack section implies executable stack
/usr/lib/gcc-cross/arm-linux-gnueabihf/12/../../../../arm-linux-gnueabihf/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
```

Should close bitcoin#1434.
  • Loading branch information
fanquake committed Nov 13, 2023
1 parent c891c5c commit 33dc7e4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/asm/field_10x26_arm.s
Expand Up @@ -913,3 +913,4 @@ secp256k1_fe_sqr_inner:
ldmfd sp!, {r4, r5, r6, r7, r8, r9, r10, r11, pc}
.size secp256k1_fe_sqr_inner, .-secp256k1_fe_sqr_inner

.section .note.GNU-stack,"",%progbits

0 comments on commit 33dc7e4

Please sign in to comment.