Fix chainRec signature to not use currying #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpominov
commented
Sep 15, 2016
| @@ -335,7 +335,7 @@ A value that implements the ChainRec specification must also implement the Chain | |||
| #### `chainRec` method | |||
|
|
|||
| ```hs | |||
| chainRec :: ChainRec m => ((a -> c) -> (b -> c) -> a -> m c) -> a -> m b | |||
| chainRec :: ChainRec m => ((((a -> c), (b -> c), a) -> m c), a) -> m b | |||
There was a problem hiding this comment.
Or should it be chainRec :: ChainRec m => ((a -> c, b -> c, a) -> m c, a) -> m b?
There was a problem hiding this comment.
Or should it be
chainRec :: ChainRec m => ((a -> c, b -> c, a) -> m c, a) -> m b?
Yes, it should be. Since we represent ternary functions as (…, …, …) -> … and , has no other meaning in our grammar, there's no need to parenthesize an argument type (even if the type is something like a -> c).
|
LGTM |
|
@safareli as you implemented this, do you want to comment on it, before we do any changes? |
|
LGTM 🌟 |
rjmk
added a commit
to rjmk/fantasy-land
that referenced
this pull request
Nov 12, 2016
* 'master' of github.com:fantasyland/fantasy-land: (29 commits) Version 2.1.0 Add Alt, Plus and Alternative specs (fantasyland#197) Use uppercase letters for Type representatives in laws (fantasyland#196) Fix id_test and argument order in laws (fantasyland#193) Version 2.0.0 Another go at updating dependencies (fantasyland#192) release: integrate xyz (fantasyland#191) test: remove unnecessary lambdas (fantasyland#190) require static methods to be defined on type representatives (fantasyland#180) lint: integrate ESLint (fantasyland#189) Enforce parametricity (fantasyland#184) readme: tweak signatures to indicate that methods are not curried (fantasyland#183) Fix reduce signature to not use currying (fantasyland#182) Link to dependent specifications (fantasyland#178) Add Fluture to the list of implementations (fantasyland#175) laws/functor: fix composition (fantasyland#173) laws/monad: fix leftIdentity (fantasyland#171) Minor version bump bower: add bower.json (fantasyland#159) Fix chainRec signature to not use currying (fantasyland#167) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with other signatures.