Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ConditionalIgnore] Allow annotation on class level #61

Open
fappel opened this issue Mar 4, 2016 · 3 comments
Open

[ConditionalIgnore] Allow annotation on class level #61

fappel opened this issue Mar 4, 2016 · 3 comments

Comments

@fappel
Copy link
Owner

fappel commented Mar 4, 2016

No description provided.

@rherrmann
Copy link
Collaborator

Neat idea!
Do you have something like this on your mind?

@Rule
@ConditionalIgnore(confition=NonMacOS.class)
public ConditionalIgnoreRule ignoreRule = new ConditionalIgnoreRule();

@fappel
Copy link
Owner Author

fappel commented Mar 4, 2016

I actually did not think it through thoroughly. I just wanted to capture the basic idea as I had to ignore ALL tests of a test case individually (Was indeed OS X related...). I think your approach would work well (except for the typo ;-)), but this would be field level access from the annotations @target point of view, right? I had the notion of putting it on the test case itself, but somehow I find your solution more intuitive.

@rherrmann
Copy link
Collaborator

Yes, that would be field level access.
I like the idea to place the annotation on the class equally well. The annotation does not affect the field it is placed on but the entire class. .In that sense, it even seems to be more 'symetric' in that, well, annotations at class level affect the whole class and method lvel annotations only the method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants