Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Videochess, Videocube and TicTacToe3D don't work #480

Closed
pseudo-rnd-thoughts opened this issue Feb 16, 2023 · 1 comment · Fixed by #481
Closed

Videochess, Videocube and TicTacToe3D don't work #480

pseudo-rnd-thoughts opened this issue Feb 16, 2023 · 1 comment · Fixed by #481

Comments

@pseudo-rnd-thoughts
Copy link
Member

The ale_py.roms.utils.rom_name_to_id doesn't correctly convert the environment name for video chess, video cube and tic-tac-toe-3d.

env_names=['TicTacToe3D', 'Videochess', 'Videocube']
converted_ids=['tic_tac_toe3_d', 'videochess', 'videocube']  # [rom_utils.rom_name_to_id(name) for name in env_names]
actual_rom_ids=['tic_tac_toe_3d', 'video_chess', 'video_cube']

As a result gym.make("ALE/TicTacToe3D-v5") raises issue, same with Videochess and Videocube.
@JesseFarebro JesseFarebro mentioned this issue Feb 17, 2023
Merged
@JesseFarebro
Copy link
Collaborator

This should now be fixed in v0.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invalid ROM names JesseFarebro/Arcade-Learning-Environment
2 participants
@JesseFarebro @pseudo-rnd-thoughts