perf(shuttle): Trim stream at regular intervals instead of every iteration #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation Performance profiling indicates that we're spending a non-trivial amount of time (5-10% of wall clock time) trimming the stream. This doesn't need to happen as frequently as it's currently happening, so switch to an interval timer so that we're not slowing down general processing in any meaningful way.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: b0905ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
Performance profiling indicates that we're spending a non-trivial amount of time (5-10% of wall clock time) trimming the stream. This doesn't need to happen as frequently as it's currently happening, so switch to an interval timer so that we're not slowing down general processing in any meaningful way.
Merge Checklist
PR-Codex overview
This PR optimizes the event stream processing in
HubEventStreamConsumerby adding a regular interval to trim old events efficiently.Detailed summary
intervalproperty to schedule event processing at regular intervalsstopmethod to clear the interval