Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ack script #2198

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix: ack script #2198

merged 1 commit into from
Jul 18, 2024

Conversation

Wazzymandias
Copy link
Contributor

@Wazzymandias Wazzymandias commented Jul 18, 2024

Why is this change needed?

  • fix: remove parentheses for prompt, which causes changes to occur in sub shell and are not persisted to the environment file

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR updates the hubble.sh script to prompt users for hub operator agreement before proceeding.

Detailed summary

  • Added a function prompt_for_hub_operator_agreement to prompt users for agreement
  • Updated the update_env_file function to handle user agreement logic
  • Added a prompt_agreement function for user input handling
  • Modified the script flow to shut down services if agreement is not given

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

…sub shell and are not persisted to the environment file
Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: 16a5487

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 8:36pm

@Wazzymandias Wazzymandias changed the title fix: remove parentheses for prompt, which causes changes to occur in … fix: ack script Jul 18, 2024
@Wazzymandias Wazzymandias added the t-bug A fix for a bug with the current system label Jul 18, 2024
@Wazzymandias Wazzymandias enabled auto-merge (squash) July 18, 2024 20:41
@Wazzymandias Wazzymandias merged commit ba79e46 into main Jul 18, 2024
8 checks passed
@Wazzymandias Wazzymandias deleted the fix/ack-script branch July 18, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant