-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use temporary directories #29
Comments
@spelunk I will consider storing the files in the temporary directory For now you can solve the issue by fixing the npm permissions
Change |
Fix doesn't work for me. |
If anyone still needs a work around, this worked for me.
|
This is very bad. Using 0.7.2 and still doesn't work. |
Using Ubuntu 18.04, I got Terminalizer to work as follows: # Install npm (requires dependencies)
sudo apt install npm node-gyp nodejs-dev libssl1.0-dev
# Install terminalizer globally
sudo npm install -g terminalizer
# Remove the electron that comes with terminalizer
sudo rm -rf /usr/local/lib/node_modules/terminalizer/node_modules/electron/
# Add electron globally - based on this SO answer https://stackoverflow.com/a/52033822/3508733
sudo npm install -g electron --unsafe-perm=true --allow-root
# By this point, I could record and play sessions, but got the error in this issue when I tried to render them.
# Symlink the hardcoded rendering path to where terminalizer is actually installed on Ubuntu
sudo mkdir -p /usr/lib/node_modules/
sudo ln -s /usr/local/lib/node_modules/terminalizer/ /usr/lib/node_modules/terminalizer
# Do the workaround above
sudo chown -R <user> /usr/lib/node_modules/terminalizer/render
sudo chmod 4775 /usr/local/lib/node_modules/electron/dist/chrome-sandbox Thanks @faressoft and @paralllax! |
I've created a Gist with these instructions and also instructions for Ubuntu 20.04. https://gist.github.com/volcan01010/6fcf7ae1f4975474ba9aac27efe17b84 I gave a thumbs down to the workaround above ( |
Hey @volcan01010 , Using your exact steps in ubuntu 20.04, I got:
I obviously tried to
Which I resolved with
And then I've given up. Are you sure you had a clean machine? I've just started this one on aws, and those instructions don't work. |
Messing with system folder permissions is not a great approach. @faressoft is there a specific reason why you have to write to a potential system folder rather than a temp folder or the current directory? |
I've just found out this also makes it impossible to open two shells and start two render processes simultaneously! |
+1 to fixing this, it sadly makes it super hard to use terminalizer on a linux system |
@faressoft are you serious? Everyone, never do something like that. As for this issue tools should not try to write anything to library paths. chmod solutions is something temporary before there is a real temp directory fix. As another temporary solution we could symlink /usr/lib/node_modules/terminalizer/render/ to /tmp or some user folder (once again, this still is not something npm users should really do). |
@faressoft could you please at least handle the issue gracefully with a message like:
I would like to use The GIF rendering is the main reason I want to use |
Why I'm still facing this issue it's 2023! |
Fixed in #226 |
Skimming the code, places hardcode the relative
render/frames/
directory. These probably should be stored in a temporary directory using a module liketempfile
The text was updated successfully, but these errors were encountered: