Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use Temporary Directory for GIF Rendering (Fixes #216) #226

Merged
merged 3 commits into from
Jul 15, 2023

Conversation

faressoft
Copy link
Owner

@faressoft faressoft commented Jul 9, 2023

This pull request addresses multiple issues and introduces improvements to the rendering process for GIF generation. The following issues have been fixed: #23, #29, #112, #175, #211, #216, #227 and #7.

The main issue encountered was a permission error preventing the rendering of GIF files. Users were unable to create the required directories due to insufficient permissions. To resolve this issue, this PR introduces the usage of a temporary directory for storing the rendered frames during the GIF generation process.

Changes Made:

  • Modified the rendering process to utilize a temporary directory for storing frames instead of the previously specified directory.
  • Updated the code to handle the temporary directory creation and cleanup automatically.

Benefits:

  • By using a temporary directory, we eliminate the need for elevated permissions or manual directory ownership changes.
  • Users can now render GIFs without encountering permission-related errors.

Testing:

  • Ran comprehensive tests to ensure proper creation and cleanup of the temporary directory.
  • Tested the rendering process with different scenarios and verified that GIFs are generated successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't Install in Ubuntu
1 participant