Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ASCII backslash encoding #151

Merged
merged 1 commit into from
Sep 23, 2021
Merged

fix ASCII backslash encoding #151

merged 1 commit into from
Sep 23, 2021

Conversation

juliangut
Copy link
Collaborator

Fix covering #148

@juliangut juliangut added this to the 0.5.0 milestone Oct 3, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.407% when pulling 85b6a23 on juliangut:fix/backslash-encoding into a530f60 on farhadi:master.

@juliangut
Copy link
Collaborator Author

@polsumeet3666 have you had time to review this PR?

@juliangut
Copy link
Collaborator Author

I'm going to hold this PR till we have confirmation from @polsumeet3666

@juliangut juliangut removed this from the 0.5.0 milestone Oct 25, 2020
@juliangut juliangut added this to the 0.6.0 milestone May 20, 2021
polsumeet3666
polsumeet3666 approved these changes Jun 11, 2021
View reviewed changes
Copy link

@polsumeet3666 polsumeet3666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backslash character is delivered to handset. issue has be resolved. tested with my SMSC

@juliangut juliangut modified the milestones: 0.6.0, 0.5.1 Sep 23, 2021
@juliangut
Copy link
Collaborator Author

Great!

merging

@juliangut juliangut merged commit 89cbc7b into farhadi:master Sep 23, 2021
@juliangut juliangut deleted the fix/backslash-encoding branch September 23, 2021 11:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polsumeet3666 polsumeet3666 polsumeet3666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@juliangut @coveralls @polsumeet3666