-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notices wp_enqueue_scrip and Gantry Framework #72
Open
mimomedia
wants to merge
11
commits into
farinspace:master
Choose a base branch
from
Flabadab:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated MediaAccess.php to use the Wordpress 3.5 Media Manager to upload.
Line 222: Removed "thickbox" class from function getButtonLink() Line 318: Changed button link <input> to <a>
Hi, sorry Flabadab, i am new user here and i think i am missing some points in understanding how github works, sorry again. Adding those commits mean i need to make each of those modifications to my files? I need to use the last one? Other thing is, i need also to change my -spec and -meta files with the structure of this new ones? Thank you |
Fixed issue with posts with thumbnail support not setting featured image.
Applied MetaBox Strict Standards fix (https://gist.github.com/Pirenko/7022890/) Changed when jQuery enqueue check is made.
Moved media scripts from __construct() to init() to avoid Strict Standard errors and changed wp_enqueue_script('jquery') to wp_enqueue_script('custom-header').
Fixed link in getButton()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i have tried to implement the Flabadab modification to use new media manager of Wp to my WpAlchemy, but get this notices and also a Warning from gantry Framework Plugin.
Anyone can point me in the right direction to get this working with no notices or warning?
Thank you very much.
Notice: wp_enqueue_script was called incorrectly. Scripts and styles should not be registered or enqueued until the wp_enqueue_scripts, admin_enqueue_scripts, or login_enqueue_scripts hooks. Please see Debugging in WordPress for more information. (This message was added in version 3.3.) in /home1/mimo/public_html/demos/solotheme/wp-includes/functions.php on line 3012
Notice: wp_enqueue_style was called incorrectly. Scripts and styles should not be registered or enqueued until the wp_enqueue_scripts, admin_enqueue_scripts, or login_enqueue_scripts hooks. Please see Debugging in WordPress for more information. (This message was added in version 3.3.) in /home1/mimo/public_html/demos/solotheme/wp-includes/functions.php on line 3012
Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at /home1/mimo/public_html/demos/solotheme/wp-includes/functions.php:3012) in /home1/mimo/public_html/demos/solotheme/wp-content/plugins/gantry/functions.php on line 182