This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Fix appraisal measurement and other improvements #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the highlight only when it actually scans and also remove it as soon as it finishes, even if couldn't scan. This might make it more visible to the user what it is doing (and for example that the scan failed).
No path lead to creating the preview on creation, fixed that.
It allows now to click the text to select a checkbox, to makes it easier to check a checkbox.
Instead of having to enable the seek bar first, just check the checkkox when the seekbar moves.
It would check that there aren't to many scans and fail at some point, but it wouldn't actually count the number of tries so it would never "fail". It would either succeed or the program exits.
The stat box is not always the same size, so we need to measure it to calibrate the length of the bars. This removes the function to determine the exact Y coordinates the bars are, because this is also relative to the size of the box.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily it does fix the issue that the size of the appraisal box is not fixed to the relations of the screen. So it now does measure the box by scanning the white lines.
Additionally this also contains a few improvements like: