Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: logger use from param & type compile #1337

Merged
merged 5 commits into from
May 25, 2024
Merged

Conversation

shulandmimi
Copy link
Member

Description:

  • logger use from param

@farm/core all logger should use from params

start({ logger: new Logger('custom prefix') });
  • binding type

move core binding swc-config.d.tsindex.d.ts to core/src/types

the previous binding config type did not participate in compilation, resulting in type reference confusion e.g: core/binding/index.d.ts JsPlugin

BREAKING CHANGE:

Related issue (if exists):

Copy link

changeset-bot bot commented May 22, 2024

🦋 Changeset detected

Latest commit: 5b0bf5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@farmfe/core Patch
@farmfe-examples/react-antd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ErKeLost ErKeLost merged commit f0f42b2 into main May 25, 2024
31 checks passed
@ErKeLost ErKeLost deleted the chore/TypeAndLogger branch May 25, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants