proto_conv #135
Merged
proto_conv #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strasdat
force-pushed
the
proto_conv
branch
4 times, most recently
from
94b1447
to
54c10a3
Compare
15 tasks
strasdat
force-pushed
the
proto_conv
branch
3 times, most recently
from
d17c62a
to
d685f8d
Compare
strasdat
force-pushed
the
proto_conv
branch
2 times, most recently
from
cf40fe7
to
3fc8f49
Compare
- use specialization instead of ADL for proto conversions
- complete unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. a event logger and playback tools which can deals with all Cpp types which are convertiable to / from Protos.
Note: If conversion is done using free functions with argument dependent lookup (ADL), all corresponding header need to be included for such tool. If on the other hand function template specialization is used, only the base case of the template definition needs to be included, and only in the context the template is instantiated, the conversion for the concrete type is required.