Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from pango2: Shared #52

Merged
merged 2 commits into from
Dec 29, 2022
Merged

from pango2: Shared #52

merged 2 commits into from
Dec 29, 2022

Conversation

strasdat
Copy link
Member

No description provided.

@strasdat strasdat marked this pull request as draft December 25, 2022 23:02
@strasdat strasdat marked this pull request as ready for review December 26, 2022 03:46
stevenlovegrove
stevenlovegrove approved these changes Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@stevenlovegrove stevenlovegrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments in case you want to simplify.

cpp/farm_ng/core/misc/copy_shared.h Show resolved Hide resolved
cpp/farm_ng/core/misc/shared.h Show resolved Hide resolved
This was referenced Dec 29, 2022
Open
Open
@strasdat strasdat merged commit ff84102 into main Dec 29, 2022
@strasdat strasdat deleted the pango-utils branch December 29, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenlovegrove stevenlovegrove stevenlovegrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@strasdat @stevenlovegrove