Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Search Bar no longer generating results #197

Closed
gbathree opened this issue Sep 26, 2023 · 3 comments
Closed

Map Search Bar no longer generating results #197

gbathree opened this issue Sep 26, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@gbathree
Copy link
Contributor

Describe the bug
Search bar in farmOS Map is no longer working. Tested in coffeeshop.farmos.net and another instance (both managed by Farmier). When you attempt to search it reports "Error! No Internet Connection?". I think this is an everywhere issue and should be quickly repeatable. It appears maybe (based on the console log, see below) that this may be a change in CORS policies for the API which would normally return the search results (?).

Expected behavior
Should search and find addresses.

Screenshots

image

This was tested in firefox (ubuntu) and probably chrome (windows), but I think this isn't a browser or OS issue.

Additional context
Add any other context about the problem here.

@gbathree gbathree added the bug Something isn't working label Sep 26, 2023
@paul121
Copy link
Member

paul121 commented Sep 26, 2023

I believe this is the issue: osm-search/Nominatim#3134

The public Nominatim Geocoding API server recently updated/was completely rewritten and introduced this change: https://github.com/osm-search/Nominatim/releases/tag/v4.3.0

Our ol-geocoding dependency needs to be updated for the currect URL path.

@mstenta
Copy link
Member

mstenta commented Sep 26, 2023

Good catch @gbathree and @paul121! It looks like this has been fixed in ol-geocoder: Dominique92/ol-geocoder#268

We may just need to update our NPM packages and publish a new release.

paul121 added a commit to paul121/farmOS-map that referenced this issue Oct 2, 2023
paul121 added a commit to paul121/farmOS-map that referenced this issue Oct 2, 2023
@mstenta
Copy link
Member

mstenta commented Oct 5, 2023

Fixed by #198.

@mstenta mstenta closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants