Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'Contributing' page #72

Merged
merged 1 commit into from
Feb 25, 2023
Merged

add 'Contributing' page #72

merged 1 commit into from
Feb 25, 2023

Conversation

wotnak
Copy link
Collaborator

@wotnak wotnak commented Feb 25, 2023

Adds 'Contributing' page as described in #62.
The page is added under the Community menu section. As noted in the issue, top-level link could also be a good place for it. Exact placement in the Community menu section is also for discussion. Currently, it is placed as the last item, but maybe moving it higher could make it more visible.

@netlify
Copy link

netlify bot commented Feb 25, 2023

Deploy Preview for gracious-brattain-bdd606 ready!

Name Link
🔨 Latest commit 355d5e2
🔍 Latest deploy log https://app.netlify.com/sites/gracious-brattain-bdd606/deploys/63fa70657bc8c200085d0a13
😎 Deploy Preview https://deploy-preview-72--gracious-brattain-bdd606.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@mstenta mstenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks @wotnak! This is great!

The page is added under the Community menu section. As noted in the issue, top-level link could also be a good place for it.

Yea I think "Community" is the right place for this...

Exact placement in the Community menu section is also for discussion. Currently, it is placed as the last item, but maybe moving it higher could make it more visible.

... and in my opinion this should be the first time under the "Community" menu!

Open to others' thoughts on this, but it seems like a good introduction to the "Community" section. And makes more sense to put this as the top item followed by the existing "Code of Conduct" item.

Copy link
Member

@paul121 paul121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @wotnak

This current CONTRIBUTING.md at the root of our repo was originally designed for the website. It serves this purpose well. But I don't think it serves the Github Contributing guidelines very well - it is too verbose IMO and could link to most of this content on farmOS.org. https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors#adding-a-contributing-file

I have an idea: what if we move the farmOS/farmOS CONTRIBUTING.md to this repo alongside the existing community content: https://github.com/farmOS/farmOS.org/tree/main/src/content/community That would simplify the site-data.js and source path logic in the repo. I think this change introduces some unnecessary compelxity.

We could then create a new simpler CONTRIBUTING.md in our farmOS/.github that links to this new farmOS.org contributing page.

@paul121
Copy link
Member

paul121 commented Feb 25, 2023

More specifically I think our Github CONTRIBUTING.md should include more technical information about how to contribute to a given repository. We have various conventions about coding standards, commit messages, updating changelog, etc... this isn't well documented and I think that file would be the correct place to do so!

And it would make this PR much simpler :-)

Copy link
Member

@paul121 paul121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bingo!

@mstenta
Copy link
Member

mstenta commented Feb 25, 2023

I like this! Good suggestions @paul121, and thanks again @wotnak for making it happen!

I will go ahead and squash+merge this, and then I will remove CONTRIBUTING.md from github.com/farmOS/farmOS, and add a new CONTRIBUTING.md to github.com/farmOS/.github which simply directs people to the farmOS.org page.

More specifically I think our Github CONTRIBUTING.md should include more technical information about how to contribute to a given repository. We have various conventions about coding standards, commit messages, updating changelog, etc... this isn't well documented and I think that file would be the correct place to do so!

Let's figure these out in follow-up(s)... I imagine each repo will need its own, since guidelines vary by project. A catch-all file in .github/CONTRIBUTING.md that directs to the website will suffice in the meantime.

We are moving this from github.com/farmOS/farmOS/CONTRIBUTING.md.
Here is the commit that originally moved it from the old farmOS.org repo:
farmOS/farmOS@4f9797e
mstenta added a commit to farmOS/farmOS that referenced this pull request Feb 25, 2023
@mstenta mstenta merged commit 355d5e2 into farmOS:main Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants