Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are not run on PR #28

Closed
paul121 opened this issue Dec 20, 2019 · 3 comments
Closed

Tests are not run on PR #28

paul121 opened this issue Dec 20, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@paul121
Copy link
Member

paul121 commented Dec 20, 2019

A current limitation of GitLab CI is that PR from forked repos are ignored (https://docs.gitlab.com/ee/ci/ci_cd_for_external_repos/#limitations)

GitLab has an issue track this here it looks like the feature could be added soon, early 2020

@paul121 paul121 added the bug Something isn't working label Dec 20, 2019
@paul121 paul121 mentioned this issue Sep 25, 2020
@cclauss
Copy link
Contributor

cclauss commented May 31, 2021

Why do we skip all tests?

$ pytest .

============================= test session starts ==============================
platform linux -- Python 3.9.5, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /home/runner/work/farmOS.py/farmOS.py
collected 33 items

tests/functional/test_area.py ssssss                                     [ 18%]
tests/functional/test_asset.py ssssss                                    [ 36%]
tests/functional/test_auth.py ssssss                                     [ 54%]
tests/functional/test_info.py s                                          [ 57%]
tests/functional/test_log.py sssssss                                     [ 78%]
tests/functional/test_term.py sssssss                                    [100%]

============================= 33 skipped in 0.07s ==============================

@paul121
Copy link
Member Author

paul121 commented May 31, 2021

hey good question @cclauss , all of the integration tests are skipped because we did not have a testing server setup at the time. But you can run those tests locally against a development server.

BUT the 1.x branch has the latest 1.0 beta release and includes automated integration tests with a 2.0 server! https://github.com/farmOS/farmOS.py/blob/1.x/.github/workflows/run-tests.yml

I think we're waiting to make that the default branch after farmOS 2.0 becomes stable. Maybe I should add a note to the current README about that

@paul121
Copy link
Member Author

paul121 commented Jan 4, 2022

This is fixed! e616acc

@paul121 paul121 closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants