Remove un-needed phpstan ignores.

See mglaman/phpstan-drupal#474
farmOS · Jan 27, 2023 · 69f1263 · 69f1263
1 parent 391acb6
commit 69f1263
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 8 deletions.
diff --git a/modules/core/ui/metrics/src/Plugin/Block/FarmMetricsBlock.php b/modules/core/ui/metrics/src/Plugin/Block/FarmMetricsBlock.php
@@ -151,8 +151,6 @@ protected function getEntityMetrics($entity_type) {
         $query->condition('status', 'active');
       }
 
-      // @todo https://github.com/mglaman/phpstan-drupal/issues/474
-      // @phpstan-ignore-next-line
       $count = $query->count()->execute();
       $route_name = "view.farm_$entity_type.page_type";
       $metrics[] = Link::createFromRoute($bundle_info['label'] . ': ' . $count, $route_name, ['arg_0' => $bundle], ['attributes' => ['class' => ['metric', 'button']]])->toString();

diff --git a/modules/core/ui/views/src/Access/FarmAssetChildrenViewsAccessCheck.php b/modules/core/ui/views/src/Access/FarmAssetChildrenViewsAccessCheck.php
@@ -63,8 +63,6 @@ public function access(RouteMatchInterface $route_match) {
 
     // Run a count query to see if there are any assets that reference this
     // asset as a parent.
-    // @todo https://github.com/mglaman/phpstan-drupal/issues/474
-    // @phpstan-ignore-next-line
     $count = $this->assetStorage->getAggregateQuery()
       ->accessCheck(TRUE)
       ->condition('parent.entity.id', $asset_id)

diff --git a/modules/core/ui/views/src/Access/FarmAssetLogViewsAccessCheck.php b/modules/core/ui/views/src/Access/FarmAssetLogViewsAccessCheck.php
@@ -62,8 +62,6 @@ public function access(RouteMatchInterface $route_match) {
     $query->condition($reference_condition);
 
     // Determine access based on the log count.
-    // @todo https://github.com/mglaman/phpstan-drupal/issues/474
-    // @phpstan-ignore-next-line
     $count = $query->execute();
     $access = AccessResult::allowedIf($count > 0);
 

diff --git a/modules/log/birth/src/Plugin/Validation/Constraint/UniqueBirthLogConstraintValidator.php b/modules/log/birth/src/Plugin/Validation/Constraint/UniqueBirthLogConstraintValidator.php
@@ -66,8 +66,6 @@ public function validate($value, Constraint $constraint) {
 
       // Query the number of birth logs that reference the asset.
       // We do not check access to ensure that all matching logs are found.
-      // @todo https://github.com/mglaman/phpstan-drupal/issues/474
-      // @phpstan-ignore-next-line
       $count = $this->entityTypeManager->getStorage('log')->getAggregateQuery()
         ->accessCheck(FALSE)
         ->condition('type', 'birth')