Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot filter the "History of Assets" in an Area #270

Closed
paul121 opened this issue Apr 4, 2020 · 2 comments
Closed

Cannot filter the "History of Assets" in an Area #270

paul121 opened this issue Apr 4, 2020 · 2 comments
Labels

Comments

@paul121
Copy link
Member

paul121 commented Apr 4, 2020

There seems to be a bug in the "History of Assets" fieldset that is included on Area pages. When submitting the form to filter or sort, the params are not posted to the current URL, but the base URL of the farmOS site. After submitting the farmOS dashboard is displayed.

History of Assets when loading the page:

Screen Shot 2020-04-04 at 10 00 27 AM

After submitting, the dashboard page is loaded with these params:

Screen Shot 2020-04-04 at 10 01 06 AM

I made sure I filled out all of the fields in the form, but still had the same issue. The other fieldsets under Assets or under Logs of Type all seem to work (Plantings, Observations, Harvests, etc) - it's just this "History of Assets" fieldset.

I'm unsure where to hunt this down... is it configured in the Views UI?

@mstenta
Copy link
Member

mstenta commented Apr 7, 2020

Ah good catch @paul121 !

I may be working on this View for another reason soon - so I can take a look.

@mstenta mstenta added the bug label Apr 7, 2020
mstenta added a commit to mstenta/farmOS that referenced this issue Apr 24, 2020
mstenta added a commit to mstenta/farmOS that referenced this issue Apr 24, 2020
@mstenta
Copy link
Member

mstenta commented Apr 24, 2020

Fixed by mstenta@31fbaeb

Applying filters will take you to a separate page now, just like the other assets/logs lists do.

I also collapsed the "History of Assets" box by default so that it doesn't take up real estate on the Area record page unless you want it to. Assuming that it is not what people are looking for most of the time, so doesn't need to be open, but it's still there when they need it.

@mstenta mstenta closed this as completed Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants