Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check php-geos requirement in the update phase #526

Merged
merged 1 commit into from Apr 22, 2022

Conversation

paul121
Copy link
Member

@paul121 paul121 commented Apr 21, 2022

Right now you cannot run update.php if the php-geos extension is not installed. This shouldn't be a blocker to running updates. I don't have php-geos at the moment in my local ddev development environment.

At first I was going to check if $phase != 'runtime' so that this requirement is only run at runtime, but I think it is good to include this during the install phase so that a warning message is displayed.

It seems like a core issue that REQUIREMENT_WARNING shouldn't block update.php but alas... the same issue here: https://www.drupal.org/project/email_noreply/issues/2184049

hook_requirements doc page for reference:
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension%21module.api.php/function/hook_requirements/10.0.x

/update.php output:
geos-update-error

@mstenta mstenta changed the title Do not check php-geos requirement in the update phase. Do not check php-geos requirement in the update phase Apr 22, 2022
@mstenta mstenta merged commit 4949c34 into farmOS:2.x Apr 22, 2022
@mstenta
Copy link
Member

mstenta commented Apr 22, 2022

Good catch @paul121 - thanks! Merged.

@paul121 paul121 deleted the 2.x-geos-update branch April 22, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants