Do not check php-geos requirement in the update phase #526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now you cannot run
update.php
if the php-geos extension is not installed. This shouldn't be a blocker to running updates. I don't have php-geos at the moment in my local ddev development environment.At first I was going to check if
$phase != 'runtime'
so that this requirement is only run at runtime, but I think it is good to include this during theinstall
phase so that a warning message is displayed.It seems like a core issue that
REQUIREMENT_WARNING
shouldn't block update.php but alas... the same issue here: https://www.drupal.org/project/email_noreply/issues/2184049hook_requirements
doc page for reference:https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension%21module.api.php/function/hook_requirements/10.0.x
/update.php
output: